Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese Word List #183

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Add Portuguese Word List #183

merged 1 commit into from
Mar 30, 2021

Conversation

ceroma
Copy link
Contributor

@ceroma ceroma commented Feb 21, 2021

Word list downloaded from: https://github.com/bitcoin/bips/tree/master/bip-0039

Updated README.md to keep language list sorted.

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ceroma! The PR itself looks good to me. 👍👍

Just noticed that this wordlist was added on 21 Dec 2020. Although it's relatively new to the crypto ecosystem, it has been included in some popular libs, e.g., bitcoinjs, BIP39 Tool. I think it's ready to go.

@hwwhww hwwhww added the enhancement New feature or request label Mar 30, 2021
@hwwhww
Copy link
Contributor

hwwhww commented Mar 30, 2021

/cc @CarlBeek for the final check.

Copy link
Collaborator

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ceroma. Sorry that this took so long!

As a side note on the Portuguese BIP39 word list, the words chosen are the same across the Brazilian and Portuguese variants, which is cool.

@CarlBeek CarlBeek merged commit da8eab9 into ethereum:dev Mar 30, 2021
@ceroma ceroma deleted the dev branch March 30, 2021 16:29
@CarlBeek CarlBeek mentioned this pull request Apr 2, 2021
1 task
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants